Skip to content

Conversation

@ShayLevi
Copy link
Contributor

@ShayLevi ShayLevi commented Dec 9, 2024

Relevant task - https://cloudinary.atlassian.net/browse/ME-17954
This test is navigating to analytics page (analytics.html) and make sure that video element is playing (checking that the video is not paused).

@ShayLevi ShayLevi requested a review from a team as a code owner December 9, 2024 08:42
@ShayLevi ShayLevi requested a review from refael-m December 9, 2024 08:42
@netlify
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit aec8247
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/6756bbf60f558b00082e2ea6
😎 Deploy Preview https://deploy-preview-750--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit aec8247
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/6756bbf6d9156b0008fda581
😎 Deploy Preview https://deploy-preview-750--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -0,0 +1,20 @@
import { vpTest } from '../fixtures/vpTest';
Copy link
Contributor

@refael-m refael-m Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the file name to analyticsPage.spec.ts, Write here all the tests for the analytics page here

Copy link
Contributor Author

@ShayLevi ShayLevi Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

* Video player examples analytics page object
*/
export class AnalyticsPage extends BasePage {
public videoAnalyticsPage: VideoComponent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a page change the name, analyticsVideoComponent maybe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@ShayLevi ShayLevi merged commit f51a1e1 into edge Dec 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants