-
Notifications
You must be signed in to change notification settings - Fork 25
me-17957: test if video on autoplay on scroll page is playing #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
021bd12
vp test: test if video on autoplay on scroll page is playing
ShayLevi c4766d0
vp test: remove waitForTimeout and use expect toPass
ShayLevi 903f15c
vp test: remove waitForTimeout and use expect toPass
ShayLevi 32576dd
vp test: added BaseComponent and modified accordingly
ShayLevi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { vpTest } from '../fixtures/vpTest'; | ||
| import { expect, test } from '@playwright/test'; | ||
| import { waitForPageToLoadWithTimeout } from '../src/helpers/waitForPageToLoadWithTimeout'; | ||
| import { getLinkByName } from '../testData/pageLinksData'; | ||
| import { ExampleLinkName } from '../testData/ExampleLinkNames'; | ||
|
|
||
| // Link to autoplay on scroll page | ||
| const link = getLinkByName(ExampleLinkName.AutoplayOnScroll); | ||
| /** | ||
| * Testing if video on autoplay on scroll page is playing. | ||
| * First making sure that video is not playing before scrolling. | ||
| * Then, scroll until video element is visible and make sure video is playing by checking that is pause return false. | ||
| */ | ||
| vpTest(`Test if video on autoplay on scroll page is playing as expected`, async ({ page, pomPages }) => { | ||
| await test.step('Navigate to autoplay on scroll page by clicking on link', async () => { | ||
| await pomPages.mainPage.clickLinkByName(link.name); | ||
| await waitForPageToLoadWithTimeout(page, 5000); | ||
| }); | ||
| await test.step('Validating that the video is not playing before scrolling (in case isPause is true)', async () => { | ||
| expect(await pomPages.autoplayOnScrollPage.autoplayOnScrollVideoComponent.isPaused()).toEqual(true); | ||
| }); | ||
| await test.step('Scroll until the video element is visible', async () => { | ||
| await pomPages.autoplayOnScrollPage.scrollToVideoElement(); | ||
| }); | ||
| await test.step('Validating that the video is auto playing after scrolling (in case isPause is false)', async () => { | ||
| expect(await pomPages.autoplayOnScrollPage.autoplayOnScrollVideoComponent.isPaused()).toEqual(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { Page } from '@playwright/test'; | ||
| import { VideoComponent } from '../../components/videoComponent'; | ||
| import { BasePage } from './BasePage'; | ||
| const AUTOPLAY_ON_SCROLL_PAGE_VIDEO_SELECTOR = '//*[@id="player_html5_api"]'; | ||
|
|
||
| /** | ||
| * Video player examples autoplay on scroll page object | ||
| */ | ||
| export class AutoplayOnScrollPage extends BasePage { | ||
| public autoplayOnScrollVideoComponent: VideoComponent; | ||
|
|
||
| constructor(page: Page) { | ||
| super(page); | ||
| this.autoplayOnScrollVideoComponent = new VideoComponent(page, AUTOPLAY_ON_SCROLL_PAGE_VIDEO_SELECTOR); | ||
| } | ||
| /** | ||
| * Scrolls the page until the video element is visible using scrollIntoViewIfNeeded method. | ||
| * This action ensures the autoplay behavior is triggered when the video comes into view. | ||
| * It waits briefly after scrolling to give the video enough time to load and trigger autoplay. | ||
| */ | ||
| async scrollToVideoElement() { | ||
| await this.page.locator(AUTOPLAY_ON_SCROLL_PAGE_VIDEO_SELECTOR).scrollIntoViewIfNeeded(); | ||
| // Wait briefly to give time for the autoplay to apply | ||
| await this.page.waitForTimeout(1000); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use waitForTimeout, use expect.toPass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the waitForTimeout and used expect.toPass in test step of validating that the video is auto playing after scrolling