me-18581: refactor specs to use validateVideoIsPlaying #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
refael-m
reviewed
Jan 1, 2025
| }); | ||
| await test.step('Validating that the first video is playing (in case isPause is false)', async () => { | ||
| expect(await pomPages.audioPlayerPage.audioPlayerVideoComponent.isPaused()).toEqual(false); | ||
| await test.step('Validating that the first audio player is playing', async () => { |
Contributor
There was a problem hiding this comment.
audio? did you mean video?
refael-m
reviewed
Jan 1, 2025
| await waitForPageToLoadWithTimeout(page, 5000); | ||
| }); | ||
| await test.step('Click on play button of first video player to play video', async () => { | ||
| await test.step('Click on play button of audio player to play video', async () => { |
refael-m
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-18581
A new function was added to video component - validateVideoIsPlaying.
The new function validates whether the video is currently playing.This method uses the
isPausedfunction to determine the current state of the video.expectedPlaying - A boolean indicating the expected playback state of the video. Pass
trueif the video is expected to be playing, orfalseif it is expected to be paused.The task was refactoring relevant specs and replace isPaused()).toEqual(false) with validateVideoIsPlaying(true)