me-17978: tests if videos are playing on vast and vpaid page #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ehab-cl
approved these changes
Jan 19, 2025
| await pomPages.vastAndVpaidPage.singleVideoWithAdsVideoComponent.validateVideoIsPlaying(true, 12000); | ||
| }); | ||
| await test.step('Validating that playlist with ads video is playing', async () => { | ||
| await pomPages.vastAndVpaidPage.playlistWithAdsVideoComponent.validateVideoIsPlaying(true); |
Contributor
There was a problem hiding this comment.
I would also specify the timeout here, this is more explicit rather than what is currently implicit (The fact that this test is using the timeout of the previous step)... this in my eyes makes the test more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17978
This test is navigating to vast and vpaid page (vast-vpaid.html) and make sure that videos element are playing.
New optional parameter called
timeoutwas added tovalidateVideoIsPlayingfunction because this page tests ads before videos and we need to wait minimum of 10 seconds until the ad finishes and the videos is starting. In all other casestimeoutis set to default of 3 seconds.