fix: Non-text contrast (WCAG 1.4.11) #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tsi
force-pushed
the
ME-19011-a11y-non-text-contrast
branch
from
782e062 to
e3612db
Compare
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kalifyaniv-cloudinary
approved these changes
Feb 12, 2025
| } | ||
|
|
||
| .vjs-slider { | ||
| background-color: color-mix(in srgb, var(--color-text) 10%, transparent); |
Contributor
There was a problem hiding this comment.
we have both --text-color and --color-text ? what is the diff?
Collaborator
Author
There was a problem hiding this comment.
Missed this, we actually have two system of color variables, an old one in JS we implemented before css-vars was a thing, then when css started supporting variable we started using that.
I would be very happy to move everything to CSS vars, it would improve the flow and reduce JS bundle size
Collaborator
Author
There was a problem hiding this comment.
This was referenced Dec 10, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the volume slider track color-contrast
Before:
After:
