fix: Contrast (Minimum) (WCAG SC 1.4.3) #817
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| // Add TitleBar as default | ||
| children.push('titleBar'); | ||
| if (children.indexOf('titleBar') === -1) { |
There was a problem hiding this comment.
why we need this "if" ?
There was a problem hiding this comment.
I was playing with colors opacity, and got weird results visually, this is how I found out the title is being rendered twice :)
This if prevents that.
There was a problem hiding this comment.
@ShayLevi could this be what's failing the test here? I couldn't find any reason why it would fail, the videos obviously play fine in the deploy preview
There was a problem hiding this comment.
@tsi is it possible that the video element id was changed? I see we have failures on multiple players page and colors API page due to that.
This PR fixes a few text color-contrast issues
Before:
After:
