me-17983: test if video is playing on ESM examples main page #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
refael-m
approved these changes
Feb 18, 2025
tsi
approved these changes
Feb 18, 2025
Collaborator
tsi
left a comment
tsi
left a comment
There was a problem hiding this comment.
Lookin good, on small note...
| export async function testMainPageVideoIsPlaying(page: Page, videoElement: VideoComponent) { | ||
| await test.step('Click on play button to play video', async () => { | ||
| await waitForPageToLoadWithTimeout(page, 5000); | ||
| return videoElement.clickPlay(); |
Collaborator
There was a problem hiding this comment.
Could this click mistakenly trigger pause instead of play? i.e. if the video is auto-playing
Contributor
Author
There was a problem hiding this comment.
The clickPlay is used only on pages/videos which are not auto-playing. The video on main pages is not auto-played so this is why we need to click on play.
Collaborator
There was a problem hiding this comment.
👍 if you need/want to be sure, you can check player is-playing status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17983
This test is navigating to ESM main page and make sure that video element are playing.
As it share common steps as mainPageVideoIsPlaying.spec.ts that was already implemented I created common spec function testMainPageVideoIsPlaying and using it on both specs.