me-17985 test if video is playing on ESM highlights graph page #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
refael-m
reviewed
Feb 18, 2025
| import { waitForPageToLoadWithTimeout } from '../../src/helpers/waitForPageToLoadWithTimeout'; | ||
| import { ESM_URL } from '../../testData/esmUrl'; | ||
|
|
||
| const link = getEsmLinkByName(ExampleLinkName.HighlightsGraph); |
refael-m
reviewed
Feb 18, 2025
| const link = getEsmLinkByName(ExampleLinkName.HighlightsGraph); | ||
| vpTest(`Test if video on ESM highlights graph page is playing as expected`, async ({ page, pomPages }) => { | ||
| await test.step('Navigate to ESM highlights graph page by clicking on link', async () => { | ||
| await page.goto(ESM_URL); |
Contributor
There was a problem hiding this comment.
add navigate at separate step
Contributor
Author
There was a problem hiding this comment.
It's navigation to the page itself. First going to ESM_URL and then clicking on the page link to open it.
Do you want me to create separate step for goto ESM_URL and separate one for opening the page?
Contributor
There was a problem hiding this comment.
I know, just wrapp it with it's own step:
await test.step('Navigate to ESM () => {
await page.goto(ESM_URL);
})
tsi
approved these changes
Feb 19, 2025
refael-m
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17985
This test is navigating to ESM highlights page (highlights-graph) and make sure that video element is playing.