me-17990: test if videos are playing on ESM chapters page #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kalifyaniv-cloudinary
approved these changes
Mar 13, 2025
|
|
||
| const link = getEsmLinkByName(ExampleLinkName.Chapters); | ||
|
|
||
| vpTest(`Test if 3 videos on ESM chapters page are playing as expected`, async ({ page, pomPages }) => { |
Contributor
There was a problem hiding this comment.
Why 3 videos? Is it critical in some one?
Asking for me to understand
Contributor
Author
There was a problem hiding this comment.
We have 3 different videos which example different uses: one is from a VTT file, second is from a config object and third one is automatically taken VTT file so I need to verify each one of them is playing.
refael-m
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17990
This test is navigating to ESM chapters page and make sure that videos element are playing.
As it share common steps as
chaptersPage.spec.tsthat was already implemented I created common spec functiontestChaptersPageVideosArePlayingand using it on both specs.