Skip to content

Conversation

@ShayLevi
Copy link
Contributor

@ShayLevi ShayLevi commented Mar 31, 2025

Relevant task - https://cloudinary.atlassian.net/browse/ME-17995
This test is navigating to ESM display configuration page and make sure that video element is playing.
As it share common steps as displayConfigurationsPage.spec.ts that was already implemented I created common spec function testDisplayConfigurationPageVideoIsPlaying and using it on both specs.
Also added autoplay attribute to video element on ESM display configuration page to be the same as the equivalent base example page (https://cloudinary.github.io/cloudinary-video-player/ui-config.html)

@netlify
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 20851c6
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/67ea56b58e8cb4000843f9a6
😎 Deploy Preview https://deploy-preview-839--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Mar 31, 2025

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 20851c6
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/67ea56b58e8cb4000843f9a8
😎 Deploy Preview https://deploy-preview-839--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShayLevi ShayLevi marked this pull request as ready for review March 31, 2025 08:54
@ShayLevi ShayLevi requested a review from a team as a code owner March 31, 2025 08:54
@ShayLevi ShayLevi requested a review from refael-m March 31, 2025 09:04
Copy link
Collaborator

@tsi tsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ShayLevi ShayLevi merged commit 3831073 into master Mar 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants