feat: visual search plugin #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kalifyaniv-cloudinary
approved these changes
Apr 3, 2025
ShayLevi
reviewed
Apr 3, 2025
| // Wait for both video elements to be ready | ||
| await test.step('Wait for video elements to be ready', async () => { | ||
| await page.waitForSelector('#player_html5_api', { state: 'visible' }); | ||
| await page.waitForSelector('#player-playlist_html5_api', { state: 'visible' }); |
Contributor
There was a problem hiding this comment.
Instead using waitForSelector you can set scrollIntoViewIfNeeded() function which is being used in other specs for that.
await pomPages.visualSearchPage.visualSearchVideoComponent.locator.scrollIntoViewIfNeeded();
await pomPages.visualSearchPage.visualSearchPlaylistVideoComponent.locator.scrollIntoViewIfNeeded();
This was referenced Dec 10, 2025
Closed
This was referenced Dec 11, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-841--cld-video-player.netlify.app/docs/visual-search