fix: internal analytics #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adimiz1
approved these changes
Oct 21, 2025
adimiz1
reviewed
Oct 21, 2025
| } : {}), | ||
| shoppable: hasConfig(sourceOptions.shoppable), | ||
| shoppableProductsLength: sourceOptions.shoppable && sourceOptions.shoppable.products && sourceOptions.shoppable.products.length, | ||
| shoppableProductsLength: hasConfig(sourceOptions.shoppable) && sourceOptions.shoppable.products.length, |
Contributor
There was a problem hiding this comment.
sourceOptions?.shoppable?.products?.length > 0
I'm wondering if this will work?
Collaborator
Author
There was a problem hiding this comment.
As a condition yes, but it will return false if length is 0, and in this specific flow, we want nulls, because false might be a valid configuration that needs to be reported to analytics (i.e. allowUsageReport: false), so if it's false we'll keep and report it, but if it's null will clean it up.
This was referenced Dec 10, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://cloudinary.atlassian.net/browse/VIDEO-20097
_s=vp-XXquery string to assets URLs (fix regression)shoppableProductsLengthwithshoppableinteractionAreasindicationFollow-up: it would be nice to append that query-string to any call coming from the player, today it will apply to the video fetching, but it would be nice to generalize it so it applies also to posters, chapters, transcript etc