chore: refactor and cleanup icons #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kalifyaniv-cloudinary
approved these changes
Oct 28, 2025
Comment on lines
-9
to
-11
| .cld-video-player-skin-light & { | ||
| background-image: url("../../assets/icons/source_switcher_icon_for_white_bg.svg"); | ||
| } |
Contributor
There was a problem hiding this comment.
im probably wrong but didnt we lose the light skin with this new implementation or its handled on the icons package?
Collaborator
Author
There was a problem hiding this comment.
No, when icons are included properly via the icon-set, you get coloring via our colors plugin, so we actually added colors support, didn't lose anything.
tsi
added a commit
that referenced
this pull request
Oct 30, 2025
* chore: simplify and test build system * docs: transformations example page * chore: refactor and cleanup icons (#923)
tsi
added a commit
that referenced
this pull request
Dec 1, 2025
* feat: fetch video-specific config * feat(VIDEO-20073): video-specific config * chore(VIDEO-20073): video-specific config simplified * chore: update unit test * chore: normalize constructor input * fix: clearer index entry-points and methods * test: video-config e2e * chore: simplify and test build system (#922) * chore: simplify and test build system * docs: transformations example page * chore: refactor and cleanup icons (#923) * chore: video_player_config path * chore: video-config internal analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.