Skip to content

fix(VIDEO-20122): Parsing VTT with cue attributes like 'align' & 'line' #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsi merged 3 commits into from
Nov 6, 2025
Merged

fix(VIDEO-20122): Parsing VTT with cue attributes like 'align' & 'line' #927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aaf8ee7
fix: Parsing VTT with cue attributes like 'align' & 'line'
tsi Nov 4, 2025
7d9ecc0
chore: cleanup
tsi Nov 4, 2025
afc39f9
Merge branch 'master' into VIDEO-20122-vtt-error
tsi Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/plugins/text-tracks-manager/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { utf8ToBase64 } from '../../utils/utf8Base64';
import { getCloudinaryUrlPrefix } from '../cloudinary/common';
import { transcriptParser } from './parsers/transcriptParser';
import { srtParser } from './parsers/srtParser';
import { vttParser } from './parsers/vttParser';
import { addTextTrackCues, fetchFileContent, refreshTextTrack, removeAllTextTrackCues } from './utils';

const getTranscriptionFileUrl = (urlPrefix, deliveryType, publicId, languageCode = null) =>
Expand Down Expand Up @@ -54,6 +53,25 @@ function textTracksManager() {
const updateTextTrackStatusToError = (textTrack, error) => updateTextTrackData(textTrack, { status: 'error', error });
const updateTextTrackStatusToApplied = (textTrack) => updateTextTrackData(textTrack, { status: 'applied' });

const addNativeVttTrack = (config) => {
const {
kind = 'subtitles',
label = 'Subtitles',
default: isDefault,
srclang,
src,
} = config;

player.addRemoteTextTrack({
kind,
label,
srclang,
src,
default: isDefault,
mode: isDefault ? 'showing' : 'disabled',
});
};

const addTextTrack = (type, config) => {
const {
kind = type === 'transcript' ? 'captions' : 'subtitles',
Expand All @@ -77,7 +95,6 @@ function textTracksManager() {

const createParser = () => {
if (type === 'srt') return srtParser;
if (type === 'vtt') return vttParser;
return (text) => transcriptParser(text, {
maxWords: config.maxWords,
wordHighlight: config.wordHighlight,
Expand Down Expand Up @@ -134,7 +151,7 @@ function textTracksManager() {
const addTextTracks = (textTracks) => {
textTracks.forEach(textTrackConfig => {
if (textTrackConfig.src && textTrackConfig.src.endsWith('.vtt')) {
addTextTrack('vtt', textTrackConfig);
addNativeVttTrack(textTrackConfig);
} else if (textTrackConfig.src && textTrackConfig.src.endsWith('.srt')) {
addTextTrack('srt', textTrackConfig);
} else if (!textTrackConfig.src || textTrackConfig.src.endsWith('.transcript')) {
Expand Down
65 changes: 0 additions & 65 deletions src/plugins/text-tracks-manager/parsers/vttParser.js
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions src/plugins/text-tracks-manager/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,22 +106,6 @@ export const removeAllTextTrackCues = (textTrack) => {
});
};

export const addNotificationCue = (videoDuration, textTrack, text) => {
if (!textTrack || !text) return;

removeAllTextTrackCues(textTrack);

const fallbackDuration = 3600;
const endTime = (
typeof videoDuration === 'number' &&
isFinite(videoDuration) &&
videoDuration > 0
) ? videoDuration : fallbackDuration;

const cue = new VTTCue(0, endTime, text);
textTrack.addCue(cue);
};

export const refreshTextTrack = (textTrack) => {
if (!textTrack || typeof textTrack.mode !== 'string') return;

Expand Down