Skip to content

#139 - Preview performance fix #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#139 - Preview performance fix #140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babc60e
#139 - Preview performance fix
mhodge13 Oct 30, 2025
e05bc56
#139 - Use jquery .each for object
mhodge13 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 41 additions & 32 deletions view/adminhtml/web/js/cms/preview-update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,55 +1,64 @@
define(
['jquery','Magento_PageBuilder/js/events','mage/url'],
function($,_PBEvents, urlBuilder){
'use strict'
['jquery','Magento_PageBuilder/js/events'],
function ($,_PBEvents) {
'use strict';
return function (config, element) {
var updateHandler = {
images: [],
let updateHandler = {
images: {},
init: function () {
let self = this;
_PBEvents.on('image:renderAfter', function (event){

_PBEvents.on('image:renderAfter', function (event) {
let elem = event.element, key = event.id;
let image = $(elem).find('img');
let src = {'remote_image': image.attr('src')};
self.images.push(src);

self.images[key] = {
key: key,
remote_image: image.attr('src')
};

self.update(key);
});
$('#save-button').on('click', function (e){
self.images.forEach(function(elem){
$('#save-button').on('click', function () {
$.each(self.images, function (key, elem) {
if (elem.cld_image) {
let cld_src = elem.cld_image;
let img = $('img[src="' + cld_src +'"]');
let img = $('img[src="' + elem.cld_image +'"]');

if (img.length) {
img.attr('src', elem.remote_image);
}
}
});
});
},
update: function(key) {
update: function (key) {
let self = this;
this.images.forEach(function(elem,ind){
$.ajax({
url: config.ajaxUrl,
type: 'POST',
dataType: 'json',
data: elem,
success: function(image) {
self.images[ind].cld_image = image;
let img = $('img[src="' + self.images[ind].remote_image +'"]');
if (img.length) {
img.attr('src', self.images[ind].cld_image);
}
},
error: function(xhr, textStatus, errorThrown) {
console.log('Error:', textStatus, errorThrown);
}
});
let imageData = self.images[key];

if (!imageData) {
return;
}

$.ajax({
url: config.ajaxUrl,
type: 'POST',
dataType: 'json',
data: { remote_image: imageData.remote_image },
success: function (image) {
self.images[key].cld_image = image;
let img = $('img[src="' + imageData.remote_image +'"]');

})
if (img.length) {
img.attr('src', image);
}
},
error: function (xhr, textStatus, errorThrown) {
console.log('Error:', textStatus, errorThrown);
}
});
}
};

return updateHandler.init();
}
};
});