Skip to content

Commit 6db464a

Browse files
committed
add support for :type parameter in publish-resources api
1 parent b9a0ea2 commit 6db464a

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/api.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ exports.create_upload_mapping = (name, callback, options = {})->
250250
call_api("post", 'upload_mappings', params, callback, options)
251251

252252
publishResource = (byKey, value, callback, options={})->
253-
params = api.only(options, "invalidate", "overwrite")
253+
params = api.only(options, "type", "invalidate", "overwrite")
254254
params[byKey] = value
255255
resource_type = options.resource_type ? "image"
256256
uri = ["resources", resource_type, "publish_resources"]

test/api_spec.coffee

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -739,7 +739,7 @@ describe "api", ->
739739
done()
740740
it "by public id", (done)->
741741
@timeout helper.TIMEOUT_LONG
742-
cloudinary.v2.api.publish_by_ids [publishTestId], (error, result)->
742+
cloudinary.v2.api.publish_by_ids [publishTestId], type: "authenticated", (error, result)->
743743
return done(new Error error.message) if error?
744744
published = result.published
745745
expect(published).not.to.be(null)
@@ -767,6 +767,15 @@ describe "api", ->
767767
expect(published[0].public_id).to.eql(publishTestId)
768768
expect(published[0].url).to.match(/\/upload\//)
769769
done()
770+
context "error", ->
771+
it "shoule return empty due to wrong type given", (done)->
772+
@timeout helper.TIMEOUT_LONG
773+
cloudinary.v2.api.publish_by_ids [publishTestId], type: "private", (error, result)->
774+
return done(new Error error.message) if error?
775+
published = result.published
776+
expect(published).not.to.be(null)
777+
expect(published.length).to.be(0)
778+
done()
770779
describe "access_mode", ->
771780
i = 0
772781
@timeout helper.TIMEOUT_LONG

0 commit comments

Comments
 (0)