Merge pull request #131 from cloudinary/hotfix/sync-status

Fix syncing status

Author: pereirinha

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-settings-page.php

@@ -913,4 +913,19 @@ public function set_active_page( $page_slug ) {
 			$this->active_page = $page_slug;
 		}
 	}
+
+	/**
+	 * Checks if auto sync feature is enabled.
+	 *
+	 * @return bool
+	 */
+	public function is_auto_sync_enabled() {
+		$settings = $this->get_config();
+
+		if ( ! empty( $settings['sync_media']['auto_sync'] ) && 'on' === $settings['sync_media']['auto_sync'] ) {
+			return true;
+		}
+
+		return false;
+	}
 }

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-sync.php

@@ -109,7 +109,7 @@ public function is_synced( $post_id ) {
 			return true;
 		}
 
-		if ( apply_filters( 'cloudinary_flag_sync', '__return_false' ) && ! get_post_meta( $post_id, Sync::META_KEYS['downloading'], true ) ) {
+		if ( $this->plugin->components['settings']->is_auto_sync_enabled() && apply_filters( 'cloudinary_flag_sync', '__return_false' ) && ! get_post_meta( $post_id, Sync::META_KEYS['downloading'], true ) ) {
 			update_post_meta( $post_id, Sync::META_KEYS['syncing'], true );
 		}
 

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/sync/class-upload-sync.php

@@ -167,7 +167,7 @@ public function handle_bulk_actions( $location, $action, $post_ids ) {
 	 * @return bool
 	 */
 	public function auto_sync_enabled( $enabled, $post_id ) {
-		if ( isset( $this->plugin->config['settings']['sync_media']['auto_sync'] ) && 'on' === $this->plugin->config['settings']['sync_media']['auto_sync'] ) {
+		if ( $this->plugin->components['settings']->is_auto_sync_enabled() ) {
 			$enabled = true;
 		}
 

cloudinary-image-management-and-manipulation-in-the-cloud-cdn/ui-definitions/tabs/sync-media-content.php

@@ -5,10 +5,7 @@
  * @package Cloudinary
  */
 
-$autosync = false;
-if ( isset( $this->plugin->config['settings']['sync_media']['auto_sync'] ) && 'on' === $this->plugin->config['settings']['sync_media']['auto_sync'] ) {
-	$autosync = true;
-}
+$autosync = $this->plugin->components['settings']->is_auto_sync_enabled();
 ?>
 <?php if ( ! empty( $this->plugin->config['connect'] ) ) : ?>
 	<div class="settings-tab-section-card">