Skip to content

fix: improve logging of errors (closes DELO-4986) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025
Merged

fix: improve logging of errors (closes DELO-4986) #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7738b16
fix: serialize errors array to string
lukaszczerpak-cloudinary Mar 12, 2025
ddff1d3
Merge remote-tracking branch 'origin/master' into DELO-4986-improve-l…
lukaszczerpak-cloudinary Mar 12, 2025
0546545
better error handling
lukaszczerpak-cloudinary Mar 12, 2025
2e96947
better error handling
lukaszczerpak-cloudinary Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cloudinary/apiCaller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,12 @@ const sendToCloudinary = (imagesArray, batchSize, dpr, metaData, quality, cb, ro
analyzeResults.push(result);
callback();
}
});
}).catch(error => {
logger.error('cloudinary upload error', error, rollBarMsg);
});
}, err => {
if (uploadErrors.length > 0) {
logger.error('cloudinary upload errors', uploadErrors, rollBarMsg);
logger.error(`cloudinary upload errors: ${uploadErrors.length} issues`, rollBarMsg);
}
if (err) {
cb({
Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/exporter-prometheus": "^0.57.1",
"@opentelemetry/instrumentation-express": "^0.47.0",
"@opentelemetry/instrumentation-http": "^0.57.1",
"@opentelemetry/exporter-prometheus": "^0.57.2",
"@opentelemetry/instrumentation-express": "^0.47.1",
"@opentelemetry/instrumentation-http": "^0.57.2",
"@opentelemetry/resources": "^1.30.1",
"@opentelemetry/sdk-node": "^0.57.1",
"@opentelemetry/sdk-node": "^0.57.2",
"@opentelemetry/sdk-trace-base": "^1.30.1",
"@opentelemetry/semantic-conventions": "^1.29.0",
"@opentelemetry/semantic-conventions": "^1.30.0",
"async": "^3.2.6",
"async-mutex": "^0.5.0",
"bytes": "^3.1.2",
Expand All @@ -36,7 +36,7 @@
"chai-http": "^4.4.0",
"husky": "^9.1.7",
"mocha": "^11.1.0",
"nock": "^14.0.0",
"nock": "^14.0.1",
"patch-package": "^8.0.0",
"sinon": "^19.0.2",
"sinon-chai": "^3.7.0"
Expand Down
2 changes: 1 addition & 1 deletion wtp/apiCaller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ const runWtpTest = async (url, mobile, cb) => {
let rollBarMsg = {testId: "", analyzedUrl: url, thirdPartyErrorCode: "", thirdPartyErrorMsg: "", file: path.basename((__filename))};
try {
response = await got(options);
logger.info("Started WPT test");
const {statusCode, body} = response;
if (statusCode !== 200) {
rollBarMsg.thirdPartyErrorCode = response.statusCode;
Expand All @@ -100,6 +99,7 @@ const runWtpTest = async (url, mobile, cb) => {
rollBarMsg.testId = (typeof bodyJson.data !== 'undefined' && typeof bodyJson.data.testId !== 'undefined') ?
(bodyJson.data.testId) :
"N/A";
logger.info("Started WPT test", {"testId": rollBarMsg.testId});
let testId = resultParser.parseTestResponse(bodyJson, rollBarMsg);
if (typeof testId === 'object') {
cb(null, testId);
Expand Down
Loading