Skip to content

Change certain DNF command failures to throw StopActorExecutionError error instead of CalledProcessError #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Change certain DNF command failures to throw StopActorExecutionError error instead of CalledProcessError #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6895c8
Change certain DNF command failures to throw StopActorExecutionError …
Jan 10, 2025
7c45dfd
Merge pull request #28 from shibutd/cloudlinux
shibutd Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions repos/system_upgrade/common/libraries/dnfconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,16 @@ def _set_excluded_pkgs(context, pkglist, disable_plugins):

try:
context.call(cmd)
except CalledProcessError:
except CalledProcessError as e:
api.current_logger().error('Cannot set the dnf configuration')
raise
raise StopActorExecutionError(
message='Cannot set the DNF configuration with the command: {}'.format(cmd),
details={
'details': 'An exception raised: {}'.format(str(e)),
'stdout': e.stdout,
'stderr': e.stderr
}
)
api.current_logger().debug('The DNF configuration has been updated to exclude leapp packages.')


Expand Down Expand Up @@ -147,7 +154,14 @@ def _set_repository_state(context, repo_id, new_state):

try:
context.call(cmd)
except CalledProcessError:
except CalledProcessError as e:
api.current_logger().error('Cannot set the dnf configuration')
raise
raise StopActorExecutionError(
message='Cannot set the DNF configuration with the command: {}'.format(cmd),
details={
'details': 'An exception raised: {}'.format(str(e)),
'stdout': e.stdout,
'stderr': e.stderr
}
)
api.current_logger().debug('Repository {} has been {}'.format(repo_id, new_state))
Loading