feat(cluster): Add support for passing inheritedMetadata to Cluster spec#494
Open
Sebastian-Materna wants to merge 8 commits intocloudnative-pg:mainfrom
Open
feat(cluster): Add support for passing inheritedMetadata to Cluster spec#494Sebastian-Materna wants to merge 8 commits intocloudnative-pg:mainfrom
Sebastian-Materna wants to merge 8 commits intocloudnative-pg:mainfrom
Conversation
Sebastian-Materna
force-pushed
the
dev/326
branch
2 times, most recently
from
705d682 to
9dc4bf6
Compare
Author
|
Any new updates here? @itay-grudev |
itay-grudev
requested changes
Feb 14, 2025
Sebastian-Materna
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
Sebastian-Materna
force-pushed
the
dev/326
branch
from
e6853d4 to
f6d36f2
Compare
Signed-off-by: Sebastian Pohl <sebastian.pohl@materna.group>
Sebastian-Materna
force-pushed
the
dev/326
branch
from
f6d36f2 to
78a4c49
Compare
dosubot
bot
added
the
size:M
Author
|
Any updates on this? |
dmavrommatis
suggested changes
Nov 5, 2025
dmavrommatis
left a comment
dmavrommatis
left a comment
There was a problem hiding this comment.
why are there so many new spaces? also the template is wrong.
Co-authored-by: Dimitris Mavrommatis <75627010+dmavrommatis@users.noreply.github.com> Signed-off-by: Sebastian Pohl <141245287+Sebastian-Materna@users.noreply.github.com>
Signed-off-by: Sebastian Pohl <141245287+Sebastian-Materna@users.noreply.github.com>
Signed-off-by: Sebastian Pohl <sebastian.pohl@materna.group>
Sebastian-Materna
force-pushed
the
dev/326
branch
from
9815aaf to
b572b9b
Compare
Signed-off-by: Sebastian Pohl <sebastian.pohl@materna.group>
Author
Removed the newlines (these were autogenerated). Also apply you suggestion, thank you. |
dmavrommatis
approved these changes
Nov 5, 2025
dosubot
bot
added
size:S
Author
|
@itay-grudev What's the deal with this PR? It's open for almost a year for a small change? |
|
Could you please approve this PR? It small change.... but without it no one can set labels on running psql pods. @itay-grudev |
Author
|
One year without any feedback of the maintainers... This is quite frustrating. |
|
Please merge this PR - the inheritedMetadata is a great addition to the cluster chart. |
Signed-off-by: Sebastian Pohl <141245287+Sebastian-Materna@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #326. PR inspired by #400.