refactor: centralise k8s context and cluster naming logic #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbartolini
changed the title
Member
|
@gbartolini you may want to take a look to this #41 |
Introduces the `get_cluster_context` and `get_cluster_name` helper functions to standardise how names are derived from environment variables. - Uses K8S_CONTEXT_PREFIX (default: kind-) and K8S_BASE_NAME (default: k8s-). - Ensures consistent string concatenation across the scripts. Signed-off-by: Gabriele Bartolini <[email protected]>
gbartolini
force-pushed
the
dev/clean-context-name
branch
from
0ad0655 to
ede886b
Compare
Contributor
Author
I have reviewed it, merged, and rebased this PR on top of that. |
mnencia
changed the title
mnencia
approved these changes
Jan 14, 2026
This was referenced Jan 14, 2026
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 14, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 14, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 14, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53 Signed-off-by: Jeremy Schneider <[email protected]>
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 15, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53 Signed-off-by: Jeremy Schneider <[email protected]>
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 15, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53 Signed-off-by: Jeremy Schneider <[email protected]>
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 15, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53 Signed-off-by: Jeremy Schneider <[email protected]>
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 15, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53 Signed-off-by: Jeremy Schneider <[email protected]>
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 15, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53 Signed-off-by: Jeremy Schneider <[email protected]>
ardentperf
added a commit
to ardentperf/cnpg-playground
that referenced
this pull request
Jan 15, 2026
after rebasing, update test scripts to use centralized logic that was introduced in cloudnative-pg#53 Signed-off-by: Jeremy Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
get_cluster_contextandget_cluster_namehelper functions to standardise how names are derived from environment variables.