generated from cloudnative-pg/cnpg-template
-
Notifications
You must be signed in to change notification settings - Fork 48
feat(sidecar): add resource requirements and limits #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e06d8f7 to
4411345
Compare
eab8044 to
990296c
Compare
mnencia
previously approved these changes
May 8, 2025
mnencia
previously approved these changes
May 9, 2025
fa84406 to
c5ad77d
Compare
Modify ObjectStore CRD to enable resources specification for the plugin's sidecar container. Signed-off-by: MichaluxPL <[email protected]>
…n stanza Add sidecar resources definition in InstanceSidecarConfiguration stanza Signed-off-by: MichaluxPL <[email protected]>
…inition for the sidecar Update reconcile functions in lifecycle.go to add resources definition for the sidecar container. Signed-off-by: MichaluxPL <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
Signed-off-by: Marco Nenciarini <[email protected]>
Document how the instance sidecar is configured and what happens when resources definitions conflict between objectstores. Signed-off-by: Francesco Canovai <[email protected]>
Document how the instance sidecar is configured and what happens when resources definitions conflict between objectstores. Signed-off-by: Francesco Canovai <[email protected]>
Signed-off-by: Francesco Canovai <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
Signed-off-by: Francesco Canovai <[email protected]>
fcanovai
previously approved these changes
May 9, 2025
mnencia
previously approved these changes
May 9, 2025
Signed-off-by: Francesco Canovai <[email protected]>
mnencia
approved these changes
May 9, 2025
gbartolini
approved these changes
May 9, 2025
fcanovai
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253