Skip to content

chore: controller-gen task should respect kubebuilder:rbac markers#426

Merged
fcanovai merged 1 commit intomainfrom
dev/413
Jul 1, 2025
Merged

chore: controller-gen task should respect kubebuilder:rbac markers#426
fcanovai merged 1 commit intomainfrom
dev/413

Conversation

@NiccoloFei
Copy link
Contributor

Closes #413

Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
@NiccoloFei NiccoloFei requested a review from a team as a code owner June 27, 2025 14:56
@NiccoloFei
Copy link
Contributor Author

Steps to test the task.

rm api/v1/zz_generated.deepcopy.go
rm config/rbac/role.yaml
rm config/crd/bases/barmancloud.cnpg.io_objectstores.yaml

task controller-gen

All the files should be properly recreated.

Edit or add a new RBAC directive, e.g.

--- a/internal/controller/objectstore_controller.go
+++ b/internal/controller/objectstore_controller.go
@@ -41,6 +41,7 @@ type ObjectStoreReconciler struct {
 // +kubebuilder:rbac:groups=barmancloud.cnpg.io,resources=objectstores,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=barmancloud.cnpg.io,resources=objectstores/status,verbs=get;update;patch
 // +kubebuilder:rbac:groups=barmancloud.cnpg.io,resources=objectstores/finalizers,verbs=update
+// +kubebuilder:rbac:groups="",resources=service,verbs=create;list;get;watch;delete

Running task controller-gen should update config/rbac/role.yaml accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI]: controller-gen task ignores rbac:roleName

3 participants