-
Notifications
You must be signed in to change notification settings - Fork 176
Update cluster create #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @TatsukiMinami, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the project's infrastructure dependencies and development toolchain. It ensures that the cluster creation process leverages more recent and potentially more stable versions of key components like Cilium and ingress-nginx. Additionally, it updates the local development environment tools and activates automated dependency management through Renovate, aiming to improve maintainability and keep the project up-to-date with minimal manual intervention. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies for various tools and Helm charts, and enables Renovate for automated dependency management. While enabling Renovate is a great step, the manual version updates in install-tools.sh and helmfile.yaml appear to use non-existent versions for all tools and charts. This will cause the installation script and Helmfile deployment to fail. I've left specific comments pointing out the invalid versions. Please correct these to valid, existing versions.
| version: 1.18.6 | ||
| values: | ||
| - values/cilium.values.yaml | ||
| - name: ingress-nginx | ||
| namespace: ingress-nginx | ||
| createNamespace: true | ||
| chart: ingress-nginx/ingress-nginx | ||
| version: 4.13.1 | ||
| version: 4.14.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specified chart versions for Cilium and ingress-nginx appear to be invalid.
cilium: version1.18.6does not seem to exist. The latest stable version is in the1.15.xrange.ingress-nginx: version4.14.1does not seem to exist. The latest stable version is in the4.10.xrange.
Using non-existent chart versions will cause helmfile to fail. Please update these to valid, available chart versions.
| readonly KIND_VERSION="v0.31.0" | ||
| readonly KUBECTL_VERSION="v1.35.0" | ||
| readonly CILIUM_CLI_VERSION="v0.19.0" | ||
| readonly HELM_VERSION="v4.1.0" | ||
| readonly HELMFILE_VERSION="1.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions specified for the tools to be installed appear to be incorrect and will likely cause the installation script to fail.
KIND_VERSION:v0.31.0does not seem to be a valid release. The latest version isv0.23.0.KUBECTL_VERSION:v1.35.0is not a valid Kubernetes release version. The latest isv1.30.0.CILIUM_CLI_VERSION:v0.19.0is not a valid version forcilium-cli. The latest isv0.16.10.HELM_VERSION:v4.1.0is a major version bump, and Helm v4 has not been released yet. The latest stable version is in the v3.x series.HELMFILE_VERSION:1.2.3does not seem to be a valid version. The latest version isv0.165.0.
Please verify the correct versions for these tools to ensure the script can download and install them successfully.
No description provided.