fix: convert ginkgo tests to standard go tests#1997
Merged
Conversation
This was referenced Jan 25, 2026
catherinetcai
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mrueg @catherinetcai
While adding some unit tests for the MSS change that was just merged, I noticed that we were only using ginkgo in a single spot in our code base. Moreover, the suite file that was in pkg/controllers that actually starts and runs the ginkgo tests doesn't apply to sub-packages, so these tests were never actually getting run, and when I created a suite file for them, they failed because they were not up to date with package changes.
This PR converts the minimal ginkgo tests that we had to standard go tests. Additionally, it updates them for the package changes that have been made since the last time the ginkgo tests actually works. Then it drops the direct Ginkgo dependency from the project.