Skip to content

fix(aws.go): load region before attempting to assume a role#2005

Merged
aauren merged 1 commit intomasterfrom
fix_aws_source_dest_check
Feb 15, 2026
Merged

fix(aws.go): load region before attempting to assume a role#2005
aauren merged 1 commit intomasterfrom
fix_aws_source_dest_check

Conversation

@aauren
Copy link
Collaborator

@aauren aauren commented Feb 14, 2026

@catherinetcai / @mrueg for review

Fixes #2004

Copy link
Collaborator

@catherinetcai catherinetcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sound to me. Wondering if there's any sort of testing we could invest in to be able to better catch things like this when doing dependency bumps :\

@aauren
Copy link
Collaborator Author

aauren commented Feb 15, 2026

Changes look sound to me. Wondering if there's any sort of testing we could invest in to be able to better catch things like this when doing dependency bumps :\

I looked into this a bit, and there are a few ways to test it, but all of them basically require integration tests to have truly caught something like this. Given how small our surface is to AWS, I think its probably a bit overboard for just now considering this is the first time that I can remember breaking it, and it would add quite a bit over overhead to the testing (probably running something like LocalStack in a container to mimic AWS APIs would be the most portable).

@aauren aauren merged commit a8dd0c2 into master Feb 15, 2026
7 checks passed
@aauren aauren deleted the fix_aws_source_dest_check branch February 15, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kube-router Fails To Disable Source/Destination Checking

2 participants