fix(NSC): add nil check for net.ParseIP result in mangle table rules#2036
Closed
Aprazor wants to merge 1 commit intocloudnativelabs:masterfrom
Closed
fix(NSC): add nil check for net.ParseIP result in mangle table rules#2036Aprazor wants to merge 1 commit intocloudnativelabs:masterfrom
Aprazor wants to merge 1 commit intocloudnativelabs:masterfrom
Conversation
Both setupMangleTableRule and cleanupMangleTableRule call net.ParseIP(ip) and immediately dereference the result with .To4() without checking for nil. If a malformed IP string reaches these functions, the nil dereference causes a panic. Add explicit nil checks that return a descriptive error instead.
Collaborator
|
Hi @Aprazor — please see my comment on #2020 (#2020 (comment)) for feedback on how to consolidate your PRs. Thanks! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both setupMangleTableRule and cleanupMangleTableRule call
net.ParseIP(ip) and immediately dereference the result with .To4()
without checking for nil. If a malformed IP string reaches these
functions, the nil dereference causes a panic. Add explicit nil
checks that return a descriptive error instead.