-
Notifications
You must be signed in to change notification settings - Fork 0
Improve server close and listen #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8c3893b
add timeout param to Server#close()
zefir-git eba07f1
cancel `closeAllConnections()` if `close()` completed in time
zefir-git 3927630
throw error if attempting to close server when not listening
zefir-git 9ab38e5
add method to resume listening
zefir-git 8a30978
listen on construct only if port provided
zefir-git a4d21d6
Merge branch '21-listening-event-promise-or-callback' into fix-server…
zefir-git d1f3080
Merge branch 'main' into fix-server-close
zefir-git 1bae72e
docs: describe `port` param in Server#listen()
zefir-git 4447f45
Merge branch 'main' into fix-server-close
zefir-git File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.