chore(perses) add helm-docs + clean up #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IB Akshay <akshay.iyyadurai.balasundaram@sap.com>
… 0.5.1 + cleanup Signed-off-by: IB Akshay <akshay.iyyadurai.balasundaram@sap.com>
Contributor
|
✅ All README.md files are up to date! Great job keeping documentation up to date! 🎉📖 |
Signed-off-by: IB Akshay <akshay.iyyadurai.balasundaram@sap.com>
Signed-off-by: IB Akshay <akshay.iyyadurai.balasundaram@sap.com>
…s and greenhouse.defaultDashboards Signed-off-by: IB Akshay <akshay.iyyadurai.balasundaram@sap.com>
richardtief
approved these changes
Mar 7, 2025
Member
richardtief
left a comment
richardtief
left a comment
There was a problem hiding this comment.
I like the quality of the Readme now. Just the object rendering as json can be messy. 😄
For e.g. perses.config
Thanks!
Signed-off-by: IB Akshay <akshay.iyyadurai.balasundaram@sap.com>
Contributor
Author
Yes, for sure. This can be messy. We don't have to add big objects such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: IB Akshay akshay.iyyadurai.balasundaram@sap.com
Submit a pull request
Thank you for submitting a pull request!
To speed up the review process, please ensure that everything below
is true:
Replace any ":question:" below with information about your pull request.
Pull Request Details
Provide details about your pull request and what it adds, fixes, or changes.
❓
Breaking Changes
Describe what features are broken by this pull request and why, if any.
❓
Issues Fixed
Enter the issue numbers resolved by this pull request below, if any.
Other Relevant Information
Provide any other important details below.
❓