Remove and deprecate unused functions

.github/workflows/generate-pickle-files.yml

@@ -0,0 +1,46 @@
+name: Generate static pickle files
+
+on: pull_request
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        python_version: [3.6, 3.7, 3.8, 3.9, "pypy3"]
+        cloudpickle_version: [1.5.0]
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Set up Python ${{ matrix.python_version }}
+      uses: actions/setup-python@v2
+      with:
+        python-version: ${{ matrix.python_version }}
+
+    - name: Install project and dependencies
+      shell: bash
+      run: python -m pip install cloudpickle==${{ matrix.cloudpickle_version }}
+
+    - name: Display Python version
+      shell: bash
+      run: python -c "import sys; print(sys.version)"
+
+    - name: List software environment
+      shell: bash
+      run: python -m pip list
+
+    - name: Generate pickle files
+      shell: bash
+      run: |
+        cd tests
+        rm -rf old_pickles
+        python generate_old_pickles.py
+        cd ../
+
+    - name: Upload pickle files
+      uses: actions/upload-artifact@v2
+      with:
+        name: old_pickles
+        path: tests/old_pickles

cloudpickle/cloudpickle.py

@@ -645,23 +645,13 @@ def parametrized_type_hint_getinitargs(obj):
     return initargs
 
 
-# Tornado support
-
-def is_tornado_coroutine(func):
-    """
-    Return whether *func* is a Tornado coroutine function.
-    Running coroutines are not supported.
-    """
-    if 'tornado.gen' not in sys.modules:
-        return False
-    gen = sys.modules['tornado.gen']
-    if not hasattr(gen, "is_coroutine_function"):
-        # Tornado version is too old
-        return False
-    return gen.is_coroutine_function(func)
-
-
 def _rebuild_tornado_coroutine(func):
+    # This function is deprecated and should be removed in cloudpickle 2.1
+    warnings.warn(
+        "A pickle file created using an old version of cloudpickle "
+        "is currently being loaded. This is no longer supported by cloudpickle and "
+        "will be removed in cloudpickle 2.1", category=FutureWarning
+    )
     from tornado import gen
     return gen.coroutine(func)
 
@@ -688,10 +678,22 @@ def dynamic_subimport(name, vars):
 
 
 def _gen_ellipsis():
+    # this function is deprecated and should be removed in cloudpickle 2.1
+    warnings.warn(
+        "a pickle file created using an old version of cloudpickle "
+        "is currently being loaded. this is no longer supported by cloudpickle and "
+        "will be removed in cloudpickle 2.1", category=FutureWarning
+    )
     return Ellipsis
 
 
 def _gen_not_implemented():
+    # This function is deprecated and should be removed in cloudpickle 2.1
+    warnings.warn(
+        "A pickle file created using an old version of cloudpickle "
+        "is currently being loaded. This is no longer supported by cloudpickle and "
+        "will be removed in cloudpickle 2.1", category=FutureWarning
+    )
     return NotImplemented
 
 
@@ -729,10 +731,7 @@ def __reduce__(cls):
 
 
 def _fill_function(*args):
-    """Fills in the rest of function data into the skeleton function object
-
-    The skeleton itself is create by _make_skel_func().
-    """
+    """Fills in the rest of function data into the skeleton function object"""
     if len(args) == 2:
         func = args[0]
         state = args[1]
@@ -809,33 +808,6 @@ def _make_cell(value=_empty_cell_value):
     return cell
 
 
-def _make_skel_func(code, cell_count, base_globals=None):
-    """ Creates a skeleton function object that contains just the provided
-        code and the correct number of cells in func_closure.  All other
-        func attributes (e.g. func_globals) are empty.
-    """
-    # This function is deprecated and should be removed in cloudpickle 1.7
-    warnings.warn(
-        "A pickle file created using an old (<=1.4.1) version of cloudpickle "
-        "is currently being loaded. This is not supported by cloudpickle and "
-        "will break in cloudpickle 1.7", category=UserWarning
-    )
-    # This is backward-compatibility code: for cloudpickle versions between
-    # 0.5.4 and 0.7, base_globals could be a string or None. base_globals
-    # should now always be a dictionary.
-    if base_globals is None or isinstance(base_globals, str):
-        base_globals = {}
-
-    base_globals['__builtins__'] = __builtins__
-
-    closure = (
-        tuple(_make_empty_cell() for _ in range(cell_count))
-        if cell_count >= 0 else
-        None
-    )
-    return types.FunctionType(code, base_globals, None, None, closure)
-
-
 def _make_skeleton_class(type_constructor, name, bases, type_kwargs,
                          class_tracker_id, extra):
     """Build dynamic class with an empty __dict__ to be filled once memoized

tests/test_backward_compat.py

@@ -17,11 +17,7 @@
 from .generate_old_pickles import PICKLE_DIRECTORY
 
 
-def load_obj(filename, check_deprecation_warning='auto'):
-    if check_deprecation_warning == 'auto':
-        # pickles files generated with cloudpickle_fast.py on old versions of
-        # coudpickle with Python < 3.8 use non-deprecated reconstructors.
-        check_deprecation_warning = (sys.version_info < (3, 8))
+def load_obj(filename, check_deprecation_warning=False):
     pickle_filepath = PICKLE_DIRECTORY / filename
     if not pickle_filepath.exists():
         pytest.skip("Could not find {}".format(str(pickle_filepath)))
@@ -61,13 +57,13 @@ def test_dynamic_module():
 
 
 def test_simple_enum():
-    enum = load_obj("simple_enum.pkl", check_deprecation_warning=False)
+    enum = load_obj("simple_enum.pkl")
     assert hasattr(enum, "RED")
     assert enum.RED == 1
     assert enum.BLUE == 2
 
     # test enum tracking feature
-    new_enum = load_obj("simple_enum.pkl", check_deprecation_warning=False)
+    new_enum = load_obj("simple_enum.pkl")
     assert new_enum is enum