Skip to content

v2.3.0

Choose a tag to compare

View all tags
@cloudposse-releaser cloudposse-releaser released this 14 Oct 13:28
· 1 commit to main since this release
v2.3.0
065ab5d
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.
component has a bug where it doesn't specify the provider for reading GitHub API key @Musthaq101 (#46) ## what * Consistent with codebase pattern: Other SSM parameter reads in data.tf and notifications.tf already use the same provider = aws.config_secrets pattern * Proper provider alias: The aws.config_secrets provider is defined in provider-secrets.tf and configured to access SSM parameters from a potentially different account/region * Correct for secrets management: GitHub credentials should be read from the designated secrets store account, not the default provider region

why

  • The v2.2.0 component has a bug where it doesn't specify the provider for reading GitHub API key.
  • Other SSM parameters (like OIDC, deploy keys, notifications) correctly use provider = aws.config_secrets, but the GitHub API key was missing this line.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

Summary by CodeRabbit

  • Bug Fixes

    • Improved reliability of secret retrieval by explicitly using the correct configuration for secure parameters, reducing intermittent failures across environments.

  • Chores

    • Standardized infrastructure configuration for fetching secrets to ensure consistency across accounts and regions. No user-facing behavior changes.

Contributors

Musthaq101
Assets 2
Loading