-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(ssm-secrets): add support for extra config options #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add support for passing `parameter_store_paths`, `resources`, `serviceAccount`, and `rbac` options to the external_ssm_secrets module. This enables more flexible configuration of the secrets operator, including custom RBAC and service account settings.
WalkthroughAdds new YAML keys to the values passed to the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main.tf(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
src/@(main|variables|outputs|providers|versions|context).tf
📄 CodeRabbit inference engine (AGENTS.md)
Keep the Terraform component’s core files (main.tf, variables.tf, outputs.tf, providers.tf, versions.tf, context.tf) in src/ as the source of truth
Files:
src/main.tf
src/**/*.tf
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.tf: Use 2-space indentation for all Terraform files
Prefer lower_snake_case for Terraform variables and locals
Keep Terraform resource and data source names descriptive and aligned with Cloud Posse null-label patterns
Run terraform fmt and do not commit formatting violations
Follow TFLint rules configured in .tflint.hcl; do not commit lint violations
Files:
src/main.tf
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
|
/terratest |
|
These changes were released in v1.537.1. |
what
parameter_store_pathsandresourcesin the values passed to theexternal_ssm_secretsmodule, enabling more granular control over which secrets and resources are managed.serviceAccountconfiguration that sets the service account name based onmodule.this.name, improving service account management.rbacconfiguration block with acreateflag controlled byvar.rbac_enabled, allowing for optional RBAC resource creation.why
external_ssm_secretsmodule to support additional customization and RBAC (Role-Based Access Control) options. The main changes expand the set of values passed to the module, allowing for more flexible and secure integration.Summary by CodeRabbit
New Features
Chores