-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add description variable for chart #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new attribute, Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main.tf (1)
21-21: Good addition—consider default/null-handling and docs updateAdding the
descriptionfield wires the previously unused variable into thehelm_release, making the chart configurable as intended. Two small follow-ups you may want to tackle:
- If
var.descriptioncan benullor empty, some Helm provider versions will still send an empty string and mark the release as “changed” on every plan/apply. Guarding withtry(var.description, null)or setting a sane default ("") invariables.tfavoids that noise.- Remember to expose the variable in the module/README inputs table so consumers see the new capability.
Nothing blocking—code is correct.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main.tf(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: component / terraform / Lint (./src)
- GitHub Check: component / terraform / Format HCL
- GitHub Check: component / terraform / bats
- GitHub Check: Summary
|
/terratest |
|
@RoseSecurity is it ready to merge? |
|
@goruha Good to go. Nothing crazy with this one |
|
These changes were released in v1.538.0. |
what
Summary by CodeRabbit