Skip to content

Added Mergify queue rules #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goruha merged 1 commit into from
Apr 24, 2025
Merged

Added Mergify queue rules #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/mergify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,3 +550,11 @@ merge_protections:
success_conditions:
- check-success = test/terratest

queue_rules:
- batch_size: 10
batch_max_wait_time: 5 m
checks_timeout: 5 m
batch_max_failure_resolution_attempts: 3
merge_method: squash
update_method: rebase
name: Test
Comment on lines +553 to +560
Copy link
Contributor

@coderabbitai coderabbitai bot Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing conditions in the queue rule; rule will never match any pull requests.

Mergify’s queue_rules require a conditions block to specify which PRs to enqueue. Without it, this rule won’t be applied. Additionally, consider moving name to the top of the block, quoting string values, and using compact duration formats (5m instead of 5 m).

Apply this diff:

 queue_rules:
-  - batch_size: 10
-    batch_max_wait_time: 5 m
-    checks_timeout: 5 m
-    batch_max_failure_resolution_attempts: 3
-    merge_method: squash
-    update_method: rebase
-    name: Test
+  - name: "Test"
+    conditions:
+      - and: *is_open
+      - and: *is_default_branch
+      - and: *checks_are_passing
+    batch_size: 10
+    batch_max_wait_time: 5m
+    checks_timeout: 5m
+    batch_max_failure_resolution_attempts: 3
+    merge_method: squash
+    update_method: rebase
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
queue_rules:
- batch_size: 10
batch_max_wait_time: 5 m
checks_timeout: 5 m
batch_max_failure_resolution_attempts: 3
merge_method: squash
update_method: rebase
name: Test
queue_rules:
- name: "Test"
conditions:
- and: *is_open
- and: *is_default_branch
- and: *checks_are_passing
batch_size: 10
batch_max_wait_time: 5m
checks_timeout: 5m
batch_max_failure_resolution_attempts: 3
merge_method: squash
update_method: rebase
🧰 Tools
🪛 YAMLlint (1.35.1)

[error] 560-560: no new line character at the end of file

(new-line-at-end-of-file)

Loading