Conversation
Signed-off-by: Igor Rodionov <goruha@gmail.com>
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Mergify as Mergify Bot
participant GitHub as GitHub Repo
Mergify->>GitHub: Read .github/mergify.yml
Mergify->>Mergify: Apply rules using short anchor aliases
Mergify->>Mergify: Use folded style for messages
Mergify->>Mergify: Ignore removed commented-out rule
Mergify->>Mergify: Apply queue rule with branch_protection_injection_mode: none
Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
/terratest |
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
|
/terratest |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/mergify.yml (2)
2-8: Consider more descriptive anchor aliases for maintainability
The concise aliases (&a4,&a1, etc.) reduce readability by obscuring the intent of each shared condition. Consider keeping minimal semantic context in your alias names (e.g.,&is_bot) or adding a mapping comment at the top to document what each alias stands for.
363-363: Remove trailing spaces
YAMLlint reports trailing spaces at lines 363 and 367. These can lead to parsing warnings or CI failures—please delete the extra whitespace at the ends of those lines.Also applies to: 367-367
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 363-363: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/mergify.yml(5 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/mergify.yml
[error] 363-363: trailing spaces
(trailing-spaces)
[error] 367-367: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Mergify Merge Protections
- GitHub Check: Mergify Merge Protections
- GitHub Check: Summary
🔇 Additional comments (1)
.github/mergify.yml (1)
484-486: Verifybranch_protection_injection_mode: nonesetting
You’ve addedbranch_protection_injection_mode: noneto the "Test" queue rule. Please confirm that:
- Your Mergify engine version supports
noneas a valid value.- Disabling branch-protection injection matches your intended workflow for that queue.
If in doubt, test a PR in a sandbox to ensure merges still obey the expected protections.
| - -author=cloudpossebot | ||
| - -author=github-actions[bot] | ||
| - -author=dependabot[bot] | ||
| - -author=renovate[bot] | ||
| - author=cloudposse-releaser[bot] |
There was a problem hiding this comment.
Fix negative author filter for not_a_bot anchor
In the not_a_bot alias, the last entry reads:
- author=cloudposse-releaser[bot]which doesn’t negate that bot. It should be:
- - author=cloudposse-releaser[bot]
+ - -author=cloudposse-releaser[bot]to correctly exclude that author.
|
These changes were released in v1.1.1. |
1 participant
This change has been made by @goruha from the Mergify Queue Rule Configurator.
Summary by CodeRabbit
Refactor
Chores