-
-
Notifications
You must be signed in to change notification settings - Fork 143
Add Codecov to Report Test Coverage #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 8 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6e01cf3
fix permissions
Cerebrovinny 4f35b25
codecov
Cerebrovinny 95d9ff3
Implement PR Size Labeler (#1098)
Cerebrovinny 8ec7ce0
Use Mergify for PR Size Comments (#1099)
Cerebrovinny 5ac750d
Merge remote-tracking branch 'origin/main'
Cerebrovinny 565bb61
Merge branch 'main' into DEV-3070
Cerebrovinny d6e170a
fix: coverage run
Cerebrovinny 8cdd73e
clean up codecov
Cerebrovinny 6986797
fix path
Cerebrovinny 0c1ef7b
add comment
Cerebrovinny 793a7f6
add comment
Cerebrovinny 0f582d1
fix path debug
Cerebrovinny e3bb2aa
fix path part 2
Cerebrovinny 4c17445
test config cov
Cerebrovinny 4383c28
test config cov
Cerebrovinny c4e08f4
test config cov
Cerebrovinny c546f85
Merge branch 'main' into DEV-3070
Cerebrovinny 17fcb40
test config cov
Cerebrovinny 054f944
test codecov config
Cerebrovinny 51f3734
update ci
Cerebrovinny 213a62e
Update codecov.yml
Cerebrovinny e00d94b
remove coverage file
Cerebrovinny 55cabff
unify tests
Cerebrovinny 4bab781
fix action codecov issue
Cerebrovinny dd98eed
Update codecov.yml
Cerebrovinny 67c5823
Update .github/workflows/test.yml
osterman 7c5e947
Update test.yml
osterman 2fcbd6a
Update test.yml
osterman c397ada
Update codecov.yml
osterman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| coverage: | ||
| precision: 2 | ||
| round: down | ||
| range: "70...100" | ||
|
|
||
| status: | ||
| patch: | ||
| default: | ||
| target: 80% # Require at least 80% test coverage on new/changed lines | ||
| threshold: 2% # Allow a small drop in coverage | ||
| base: auto | ||
Cerebrovinny marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| informational: false # Fail the PR check if coverage is too low | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the harm in always running with coverage enabled? Want to understand if a separate target is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I decided to split it to maintain the same behavior as before locally. I don’t think it makes a difference in CI, so we can keep it. The only downside I see is if we don’t need coverage locally