Fix #964

[Nuru]

what

• Fix wrapper to be compatible with bash 3.2
• Prefer NAMESPACE (if set) to basename $DOCKER_IMAGE as default for APP_NAME

why

• bash 3.2 was the last GPL licensed version and is what ships with macOS
• Better reflect common usage

references

• Fixes Geodesic v4 Wrapper Script Case Termination Operator Incompatible with Bash 3.2 #964

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the parse_args function in the wrapper-body.sh script by replacing the incompatible case termination operator (;&) with a comment that indicates the use of Bash 4.0’s feature. It appends the argument related to the --workspace option into the options array. Additionally, the error message in _40-preferences.sh has been updated to dynamically include the application name based on the NAMESPACE or DOCKER_IMAGE variables. The APP_NAME variable in bootstrap has also been modified to incorporate the NAMESPACE variable.

Changes

Files	Change Summaries
rootfs/templates/wrapper-body.sh	Modified parse_args: replaced the Bash 4.0-specific ;& operator with a comment for Bash 3.2 compatibility and added a line to append arg to options array.
rootfs/etc/profile.d/_40-preferences.sh	Updated error message to dynamically include application name based on NAMESPACE or DOCKER_IMAGE.
rootfs/templates/bootstrap	Changed APP_NAME assignment to include NAMESPACE variable, defaulting to DOCKER_IMAGE basename.

Assessment against linked issues

Objective	Addressed	Explanation
Replace incompatible case operator (;&) for Bash 3.2 (#964)	✅

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ea4290 and 5c8e126.

📒 Files selected for processing (3)

• rootfs/etc/profile.d/_40-preferences.sh (1 hunks)
• rootfs/templates/bootstrap (2 hunks)
• rootfs/templates/wrapper-body.sh (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• rootfs/templates/wrapper-body.sh

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-and-push (debian)

🔇 Additional comments (3)

rootfs/templates/bootstrap (2)

4-4: LGTM! More robust fallback chain for APP_NAME.

The enhanced fallback chain ${APP_NAME:-${NAMESPACE:-$(basename ${DOCKER_IMAGE:-geodesic})}} prevents unset variable errors and maintains bash 3.2 compatibility.

---

93-93: LGTM! Improved bash 3.2 compatibility.

Good addition of the command -v hash check before hash -r. This prevents errors on systems where the hash builtin is not available.

rootfs/etc/profile.d/_40-preferences.sh (1)

59-59: LGTM! Consistent application naming in error messages.

The error message now uses the same APP_NAME fallback chain as defined in the bootstrap script, ensuring consistency across the application.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.