Skip to content

Support plan-diff #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 124 commits into from
Aug 14, 2025
Merged

Support plan-diff #77

merged 124 commits into from
Aug 14, 2025

Conversation

goruha
Copy link
Member

@goruha goruha commented Aug 5, 2025 •
edited
Loading

what

  • Use atmos terraform plan-diff to ensure stored plan is actual
  • Added tests for
    • Basic apply usage
    • Apply with storage disabled
    • Apply with atmos pro
    • Apply when plan-diff has changes
    • Apply when plan generation fail
  • Updated README with migration plan for new v5 action
  • Added Github Action summaries for cases plan-diff found changes and plan generation failed
  • Updated terraform-docs to v0.20.0

why

  • Guarantee that the plan we saw on GitOps plan stage would be the same one we apply.
  • Improve test coverage to be confident in GHA behaviour
  • Provide documentation to users about the changes
  • Provide a nice feedback message in the GitHub UI for the action
  • Get the latest bug fixes

@goruha goruha requested review from a team as code owners August 5, 2025 13:37
@goruha goruha requested review from hans-d and kevcube August 5, 2025 13:37
goruha added 21 commits August 9, 2025 19:15
@goruha
Plan diff support skip init flag
e7f46be
@goruha
Plan diff support skip init flag
431ed61
@goruha
Plan diff support skip init flag
8c970cd
@goruha
Plan diff support skip init flag
438921d
@goruha
Plan diff support skip init flag
d8ce095
@goruha
Plan diff support skip init flag
3d052c9
@goruha
Plan diff support skip init flag
1839ef3
@goruha
Plan diff support skip init flag
57da58b
@goruha
Plan diff support skip init flag
5e4805c
@goruha
Plan diff support skip init flag
200afd8
@goruha
Plan diff support skip init flag
f009748
@goruha
Plan diff support skip init flag
137053b
@goruha
Plan diff support skip init flag
0cf2785
@goruha
Plan diff support skip init flag
6201877
@goruha
Plan diff support skip init flag
3ef368d
@goruha
Plan diff support skip init flag
2f033eb
@goruha
Plan diff support skip init flag
6bbb1b9
@goruha
Plan diff support skip init flag
6daa7ed
@goruha
Plan diff support skip init flag
f81da09
@goruha
Plan diff support skip init flag
9ab66e2
@goruha
Plan diff support skip init flag
67a9e87
@goruha goruha added the major Breaking changes (or first stable release) label Aug 10, 2025
This was referenced Aug 10, 2025
Closed
Closed
Benbentwo
Benbentwo approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but have some concerns about 60+ line bash scripts

@goruha goruha merged commit 267eec5 into main Aug 14, 2025
19 of 23 checks passed
@goruha goruha deleted the plan-diff branch August 14, 2025 13:26
@github-actions GitHub Actions
Copy link

These changes were released in v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Benbentwo Benbentwo Benbentwo approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goruha @osterman @Benbentwo