Convert to TF 0.12. Add tests. Add Codefresh test pipeline (#12)

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

* Convert to TF 0.12. Add tests. Add Codefresh test pipeline

Author: aknysh

.gitignore

@@ -5,13 +5,13 @@
 *.tfstate
 *.tfstate.*
 
-# .tfvars files
-*.tfvars
-
 **/node_modules/*
 **/package-lock.json
 
 .build-harness
 build-harness
 
 *.zip
+
+*.iml
+.idea

.travis.yml

@@ -186,7 +186,7 @@
       same "printed page" as the copyright notice for easier
       identification within third-party archives.
 
-   Copyright 2018 Cloud Posse LLC
+   Copyright 2018-2019 Cloud Posse LLC
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.

LICENSE

@@ -18,9 +18,9 @@ github_repo: cloudposse/terraform-aws-ses-lambda-forwarder
 
 # Badges to display
 badges:
-  - name: "Build Status"
-    image: "https://travis-ci.org/cloudposse/terraform-aws-ses-lambda-forwarder.svg?branch=master"
-    url: "https://travis-ci.org/cloudposse/terraform-aws-ses-lambda-forwarder"
+  - name: "Codefresh Build Status"
+    image: "https://g.codefresh.io/api/badges/pipeline/cloudposse/terraform-modules%2Fterraform-aws-ses-lambda-forwarder?type=cf-1"
+    url: "https://g.codefresh.io/public/accounts/cloudposse/pipelines/5defd0c4158ef27f981fe4dd"
   - name: "Latest Release"
     image: "https://img.shields.io/github/release/cloudposse/terraform-aws-ses-lambda-forwarder.svg"
     url: "https://github.com/cloudposse/terraform-aws-ses-lambda-forwarder/releases/latest"
@@ -43,26 +43,31 @@ introduction: |-
 
   For example, an email sent by `John Doe <[email protected]>` to `[email protected]` will be transformed to:
   ```
-  From: John Doe at [email protected] <[email protected]> 
+  From: John Doe at [email protected] <[email protected]>
   Reply-To: [email protected]
   ```
 
-  To override this behavior, set a verified `fromEmail` address (e.g., `[email protected]`) in the config 
+  To override this behavior, set a verified `fromEmail` address (e.g., `[email protected]`) in the config
   object and the header will look like this.
   ```
   From: John Doe <[email protected]>
   Reply-To: [email protected]
   ```
 
-  __NOTE__: SES only allows receiving email sent to addresses within verified domains. For more information, 
+  __NOTE__: SES only allows receiving email sent to addresses within verified domains. For more information,
   see: http://docs.aws.amazon.com/ses/latest/DeveloperGuide/verify-domains.html
   ```
 
-  Initially SES users are in a sandbox environment that has a number of limitations. See: 
+  Initially SES users are in a sandbox environment that has a number of limitations. See:
   http://docs.aws.amazon.com/ses/latest/DeveloperGuide/limits.html
 
 # How to use this project
 usage: |-
+
+  For a complete example, see [examples/complete](examples/complete).
+
+  For automated tests of the complete example using [bats](https://github.com/bats-core/bats-core) and [Terratest](https://github.com/gruntwork-io/terratest) (which tests and deploys the example on AWS), see [test](test).
+
   ```hcl
   variable "relay_email" {
     default     = "[email protected]"
@@ -80,19 +85,21 @@ usage: |-
     description = "Emails forward map"
   }
 
-  module "ses" {
-    source = "git::https://github.com/cloudposse/terraform-aws-ses-lambda-forwarder.git?ref=tags/0.1.0"
-
-    namespace = "${var.namespace}"
-    name      = "${var.ses_name}"
-    stage     = "${var.stage}"
+  module "ses_lambda_forwarder" {
+    source = "git::https://github.com/cloudposse/terraform-aws-ses-lambda-forwarder.git?ref=master"
 
-    region = "${var.ses_region}"
+    namespace  = var.namespace
+    stage      = var.stage
+    name       = var.name
+    delimiter  = var.delimiter
+    attributes = var.attributes
+    tags       = var.tags
 
-    relay_email = "${var.relay_email}"
-    domain      = "${var.parent_domain_name}"
+    region = var.region
+    domain = var.domain
 
-    forward_emails = "${var.forward_emails}"
+    relay_email    = var.relay_email
+    forward_emails = var.forward_emails
   }
   ```
 
@@ -108,4 +115,8 @@ include:
 # Contributors to this project
 contributors:
   - name: "Igor Rodionov"
-    github: "goruha"
+    github: "goruha"
+  - name: "Erik Osterman"
+    github: "osterman"
+  - name: "Andriy Knysh"
+    github: "aknysh"

README.md

@@ -0,0 +1,77 @@
+version: '1.0'
+
+stages:
+  - Prepare
+  - Test
+
+steps:
+  wait:
+    title: Wait
+    stage: Prepare
+    image: codefresh/cli:latest
+    commands:
+      - codefresh get builds --pipeline=${{CF_REPO_NAME}} --status running --limit 1000 -o json | jq --arg id ${{CF_BUILD_ID}} -ser 'flatten|.[-1].id==$id'
+    retry:
+      maxAttempts: 10
+      delay: 20
+      exponentialFactor: 1.1
+
+  main_clone:
+    title: "Clone repository"
+    type: git-clone
+    stage: Prepare
+    description: "Initialize"
+    repo: ${{CF_REPO_OWNER}}/${{CF_REPO_NAME}}
+    git: CF-default
+    revision: ${{CF_REVISION}}
+
+  clean_init:
+    title: Prepare build-harness and test-harness
+    image: ${{TEST_IMAGE}}
+    stage: Prepare
+    commands:
+      - cf_export PATH="/usr/local/terraform/0.12/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
+      - make init
+      - git -C build-harness checkout master
+      - make -C test/ clean init TEST_HARNESS_BRANCH=master
+      - make -C test/src clean init
+      - find . -type d -name '.terraform' | xargs rm -rf
+      - find . -type f -name 'terraform.tfstate*' -exec rm -f {} \;
+
+  test:
+    type: "parallel"
+    title: "Run tests"
+    description: "Run all tests in parallel"
+    stage: Test
+    steps:
+      test_readme_lint:
+        title: "Test README.md updated"
+        stage: "Test"
+        image: ${{TEST_IMAGE}}
+        description: Test "readme/lint"
+        commands:
+          - make readme/lint
+
+      test_module:
+        title: Test module with bats
+        image: ${{TEST_IMAGE}}
+        stage: Test
+        commands:
+          - make -C test/ module
+
+      test_examples_complete:
+        title: Test "examples/complete" with bats
+        image: ${{TEST_IMAGE}}
+        stage: Test
+        commands:
+          - make -C test/ examples/complete
+
+      test_examples_complete_terratest:
+        title: Test "examples/complete" with terratest
+        image: ${{TEST_IMAGE}}
+        stage: Test
+        commands:
+          - unset AWS_PROFILE
+          - unset AWS_DEFAULT_PROFILE
+          - unset AWS_MFA_PROFILE
+          - make -C test/src

README.yaml

@@ -2,8 +2,9 @@
 ```
 Available targets:
 
-  help                                This help screen
+  help                                Help screen
   help/all                            Display help for all targets
+  help/short                          This help short screen
   lint                                Lint terraform code
 
 ```

codefresh/test.yml

@@ -1,17 +1,41 @@
-
 ## Inputs
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| attributes | Additional attributes (e.g. `1`) | list | `<list>` | no |
+| artifact_filename | Artifact filename | string | `lambda.zip` | no |
+| artifact_url | URL template for the remote artifact | string | `https://artifacts.cloudposse.com/$$${module_name}/$$${git_ref}/$$${filename}` | no |
+| attributes | Additional attributes (e.g. `1`) | list(string) | `<list>` | no |
 | delimiter | Delimiter to be used between `namespace`, `stage`, `name` and `attributes` | string | `-` | no |
 | domain | Root domain name | string | - | yes |
-| forward_emails | Emails forward map | map | `<map>` | no |
+| forward_emails | Map of forward emails | map(list(string)) | `<map>` | no |
+| lambda_runtime | Lambda runtime | string | `nodejs8.10` | no |
 | name | Application or solution name (e.g. `app`) | string | `ses` | no |
-| namespace | Namespace (e.g. `cp` or `cloudposse`) | string | - | yes |
-| region | AWS Region the SES should reside in | string | `us-west-2` | no |
+| namespace | Namespace (e.g. `cp` or `cloudposse`) | string | `` | no |
+| region | AWS Region the SES should reside in | string | - | yes |
 | relay_email | Email that used to relay from | string | - | yes |
 | spf | DNS SPF record value | string | `v=spf1 include:amazonses.com -all` | no |
-| stage | Stage (e.g. `prod`, `dev`, `staging`) | string | - | yes |
-| tags | Additional tags (e.g. map(`BusinessUnit`,`XYZ`) | map | `<map>` | no |
+| stage | Stage (e.g. `prod`, `dev`, `staging`) | string | `` | no |
+| tags | Additional tags (e.g. map(`BusinessUnit`,`XYZ`) | map(string) | `<map>` | no |
+
+## Outputs
+
+| Name | Description |
+|------|-------------|
+| artifact_base64sha256 | Base64 encoded SHA256 hash of the artifact file |
+| artifact_file | Full path to the locally downloaded artifact |
+| artifact_git_ref | Git commit hash corresponding to the artifact |
+| artifact_url | URL corresponding to the artifact |
+| lambda_function_arn | Lamnda Function ARN |
+| lambda_function_source_code_size | The size in bytes of the Lambda Function .zip file |
+| lambda_function_version | Latest published version of the Lambda Function |
+| lambda_iam_policy_arn | Lamnda IAM Policy ARN |
+| lambda_iam_policy_id | Lamnda IAM Policy ID |
+| lambda_iam_policy_name | Lamnda IAM Policy name |
+| s3_bucket_arn | Lamnda IAM Policy ARN |
+| s3_bucket_domain_name | Lamnda IAM Policy ARN |
+| s3_bucket_id | Lamnda IAM Policy name |
+| ses_domain_identity_arn | The ARN of the domain identity |
+| ses_domain_identity_verification_arn | The ARN of the domain identity |
+| ses_receipt_rule_name | The name of the SES receipt rule |
+| ses_receipt_rule_set_name | The name of the SES receipt rule set |
 

docs/targets.md

@@ -1,42 +1,40 @@
 data "aws_route53_zone" "default" {
-  name    = "${var.domain}"
-  comment = "Root DNS Zone"
+  name = var.domain
 }
 
 resource "aws_route53_record" "default" {
-  zone_id = "${data.aws_route53_zone.default.zone_id}"
+  zone_id = data.aws_route53_zone.default.zone_id
   name    = "_amazonses.${aws_ses_domain_identity.default.id}"
   type    = "TXT"
   ttl     = "600"
-  records = ["${aws_ses_domain_identity.default.verification_token}"]
+  records = [aws_ses_domain_identity.default.verification_token]
 }
 
 # Add Route53 MX record
 resource "aws_route53_record" "mx" {
-  zone_id = "${data.aws_route53_zone.default.zone_id}"
-  name    = "${aws_ses_domain_identity.default.id}"
+  zone_id = data.aws_route53_zone.default.zone_id
+  name    = aws_ses_domain_identity.default.id
   type    = "MX"
   ttl     = "600"
   records = ["10 inbound-smtp.${var.region}.amazonaws.com"]
-
-  # Change to the region in which `aws_ses_domain_identity.example` is created
+  # Change to the region in which `aws_ses_domain_identity.default` is created
 }
 
 # Add Route53 TXT record for SPF
 resource "aws_route53_record" "txt" {
-  zone_id = "${data.aws_route53_zone.default.zone_id}"
-  name    = "${aws_ses_domain_identity.default.id}"
+  zone_id = data.aws_route53_zone.default.zone_id
+  name    = aws_ses_domain_identity.default.id
   type    = "TXT"
   ttl     = "600"
-  records = ["${var.spf}"]
+  records = [var.spf]
 }
 
 resource "aws_ses_domain_identity" "default" {
-  domain = "${var.domain}"
+  domain = var.domain
 }
 
 resource "aws_ses_domain_identity_verification" "default" {
-  domain = "${aws_ses_domain_identity.default.id}"
+  domain = aws_ses_domain_identity.default.id
 
-  depends_on = ["aws_route53_record.default"]
+  depends_on = [aws_route53_record.default]
 }

docs/terraform.md

@@ -0,0 +1,17 @@
+#  Local .terraform directories
+**/.terraform/*
+
+# .tfstate files
+*.tfstate
+*.tfstate.*
+
+**/node_modules/*
+**/package-lock.json
+
+.build-harness
+build-harness
+
+*.zip
+
+*.iml
+.idea