Skip to content

Refactor PowerShell execution logic to prioritize "powershell" on Windows #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor PowerShell execution logic to prioritize "powershell" on Windows #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tasks/powershell/execute-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ async function run() {
const input_failOnStderr = tl.getBoolInput('failOnStderr', false);
const input_ignoreLASTEXITCODE = tl.getBoolInput('ignoreLASTEXITCODE', false);
const input_workingDirectory = tl.getPathInput('workingDirectory', /*required*/ true, /*check*/ true);
const input_pwsh: boolean = tl.getBoolInput('pwsh', false);

let input_filePath: string;
let input_arguments: string;
Expand Down Expand Up @@ -107,15 +108,23 @@ async function run() {

// Run the script.
//
// Note, prefer "pwsh" over "powershell". At some point we can remove support for "powershell".
// Note, prefer "powershell" over "pwsh" on Windows unless the pwsh input is true.
//
// Note, use "-Command" instead of "-File" to match the Windows implementation. Refer to
// comment on Windows implementation for an explanation why "-Command" is preferred.
console.log('========================== Starting Command Output ===========================');

const executionOperator = input_runScriptInSeparateScope ? '&' : '.';
const powershell = tl.tool(tl.which('pwsh') || tl.which('powershell') || tl.which('pwsh', true))
.arg('-NoLogo')
const isWindows = os.platform() === 'win32';

let powershell: tr.ToolRunner;
if (input_pwsh || !isWindows) {
powershell = tl.tool(tl.which('pwsh') || tl.which('powershell') || tl.which('pwsh', true));
} else {
powershell = tl.tool(tl.which('powershell') || tl.which('pwsh') || tl.which('powershell', true));
}

powershell.arg('-NoLogo')
.arg('-NoProfile')
.arg('-NonInteractive')
.arg('-Command')
Expand Down