Skip to content

Commit f5d01c9

Browse files
authored
fix(testdata): Add missing column types (#1061)
Just add the missing ones. Supercedes #1057
1 parent 57c7bc2 commit f5d01c9

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

schema/testdata.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ func TestTable(name string, opts TestSourceOptions) *Table {
7070
Columns: make(ColumnList, 0),
7171
}
7272
var columns ColumnList
73-
// primitive columns
7473
columns = append(columns, ColumnList{
74+
// primitive columns
7575
{Name: "int8", Type: arrow.PrimitiveTypes.Int8},
7676
{Name: "int16", Type: arrow.PrimitiveTypes.Int16},
7777
{Name: "int32", Type: arrow.PrimitiveTypes.Int32},
@@ -82,8 +82,17 @@ func TestTable(name string, opts TestSourceOptions) *Table {
8282
{Name: "uint64", Type: arrow.PrimitiveTypes.Uint64},
8383
{Name: "float32", Type: arrow.PrimitiveTypes.Float32},
8484
{Name: "float64", Type: arrow.PrimitiveTypes.Float64},
85+
86+
// basic columns
8587
{Name: "binary", Type: arrow.BinaryTypes.Binary},
8688
{Name: "string", Type: arrow.BinaryTypes.String},
89+
{Name: "boolean", Type: arrow.FixedWidthTypes.Boolean},
90+
91+
// extension types
92+
{Name: "uuid", Type: types.NewUUIDType()},
93+
{Name: "inet", Type: types.NewInetType()},
94+
{Name: "mac", Type: types.NewMACType()},
95+
{Name: "json", Type: types.NewJSONType()},
8796
}...)
8897
if !opts.SkipDates {
8998
columns = append(columns, ColumnList{
@@ -136,6 +145,7 @@ func TestTable(name string, opts TestSourceOptions) *Table {
136145
if !opts.SkipDecimals {
137146
columns = append(columns, ColumnList{
138147
{Name: "decimal128", Type: &arrow.Decimal128Type{Precision: 19, Scale: 10}},
148+
// {Name: "decimal256", Type: &arrow.Decimal256Type{Precision: 40, Scale: 10}},
139149
}...)
140150
}
141151

0 commit comments

Comments
 (0)