fix: Ignore context cancelled errors.#2091
Merged
kodiakhq[bot] merged 2 commits intomainfrom Mar 7, 2025
Merged
Conversation
hermanschaaf
approved these changes
Mar 7, 2025
disq
approved these changes
Mar 7, 2025
erezrokah
approved these changes
Mar 7, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
🤖 I have created a release *beep* *boop* --- ## [4.74.0](v4.73.4...v4.74.0) (2025-03-07) ### Features * Add description to time JSONschema ([#2083](#2083)) ([fc27b14](fc27b14)) * Add way to get Configtype time value for hashing ([#2077](#2077)) ([ed27292](ed27292)) * Add WithNullableFieldTransformer to transformers.TransformWithStruct options ([#2084](#2084)) ([2175946](2175946)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#2074](#2074)) ([091e2c7](091e2c7)) * **deps:** Update aws-sdk-go-v2 monorepo ([#2080](#2080)) ([14ad9db](14ad9db)) * **deps:** Update aws-sdk-go-v2 monorepo ([#2085](#2085)) ([3da5572](3da5572)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.13.6 ([#2089](#2089)) ([4faff6a](4faff6a)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.7 ([#2076](#2076)) ([dbdae2f](dbdae2f)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.8 ([#2090](#2090)) ([c4c9cd6](c4c9cd6)) * **deps:** Update module github.com/goccy/go-json to v0.10.5 ([#2086](#2086)) ([b238237](b238237)) * **deps:** Update module github.com/google/go-cmp to v0.7.0 ([#2088](#2088)) ([1895ddf](1895ddf)) * **deps:** Update module google.golang.org/protobuf to v1.36.5 ([#2081](#2081)) ([833b19c](833b19c)) * Ignore context cancelled errors. ([#2091](#2091)) ([bc50fd3](bc50fd3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/cloudquery/cloudquery-issues/issues/3451
The CLI closes the context that the Transformer plugin uses upon completion of the sync. This is not an error, so the SDK should not raise it in the
Transformfunction.This error is benign in that the sync still works as expected, but it looks bad in the logs, which end up showing up in
cloudquery.log, and it bubbles up to other products like Asset Inventory which happens to show errors in bright red colours.Here's a typical current run
Here's a fixed run