feat: Add internal columns helpers#2105
Merged
kodiakhq[bot] merged 1 commit intomainfrom Mar 31, 2025
Merged
Conversation
erezrokah
requested review from
a team,
Copilot and
savme
and removed request for
savme
There was a problem hiding this comment.
Pull Request Overview
This pull request adds helper functions to add internal columns to Apache Arrow records, supporting internal CQ columns functionality. Key changes include the implementation of new functions (e.g., hashRecord, nullUUIDsForRecord, StringArrayFromValue, TimestampArrayFromTime, ReplaceFieldInRecord, and AddInternalColumnsToRecord) in schema/arrow.go and corresponding tests in schema/arrow_test.go.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| schema/arrow_test.go | Adds test records and unit tests for new internal columns helpers. |
| schema/arrow.go | Implements helper functions for internal column handling. |
murarustefaan
approved these changes
Mar 31, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
🤖 I have created a release *beep* *boop* --- ## [4.75.0](v4.74.2...v4.75.0) (2025-03-31) ### Features * Add internal columns helpers ([#2105](#2105)) ([1dea99c](1dea99c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Mar 31, 2025
#### Summary Goes with cloudquery/plugin-sdk#2105 For Cloud syncs we should replace the internal columns if exist so we can trace back the synced data to the correct source name, sync time and sync group id (otherwise we'd get the ones of the original sync, e.g. `AWS->S3`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://github.com/cloudquery/cloud/pull/4919 (internal issue).
Adds some useful helpers to deal with adding CQ internal columns
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)