chore: Double the limit of grpc messages#2131
Conversation
|
I'm wondering if we need to change it here as well; probably not required, since |
Co-authored-by: Bartosz Lesniewski <bartosz@cloudquery.io>
@murarustefaan Not sure here, I have to find out how that code is actually used. |
|
@murarustefaan I think you are right, this could be also needed due to destination client size limit in CLI. |
|
Nice! Then let's merge that one, get it out and upgrade the dependency version in the SDK here and only then get this one merged. |
|
@murarustefaan Released and updated |
|
Seems like I have to update plugins first 🤔 |
Summary
Following up on the transformer hanging issue reported by a customer and addressed in PR #2130:
Currently, the transformer plugin can increase the message size beyond the limit enforced in the sync method of plugin-sdk 1.
To accommodate scenarios where transformers or destination plugins need to handle larger messages than the source plugin, we should consider increasing this limit to provide more flexibility.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)