Skip to content

fix: Correctly validate backend_options configuration #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
May 30, 2025
Merged

fix: Correctly validate backend_options configuration #2182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02498ce
fix: Correctly validate backend_options configuration
murarustefaan May 30, 2025
5ec0193
fix: error on incorrectly configured backend_options
murarustefaan May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion state/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,16 @@ func NewConnectedClient(ctx context.Context, backendOpts *plugin.BackendOptions)
// The state client is guaranteed to be non-nil (it defaults to the NoOpClient).
// You must call Close() on the returned Client object.
func NewConnectedClientWithOptions(ctx context.Context, backendOpts *plugin.BackendOptions, connOpts ConnectionOptions, clOpts ClientOptions) (Client, error) {
if backendOpts == nil {
// backend_options missing or configured but empty
if backendOpts == nil || (backendOpts.Connection == "" && backendOpts.TableName == "") {
return &NoOpClient{}, nil
}

// backend_options configured incorrectly, e.g. missing connection or table_name
if backendOpts.Connection == "" || backendOpts.TableName == "" {
return nil, fmt.Errorf("backend_options must contain both connection and table_name: %v", backendOpts)
}

backendConn, err := grpc.NewClient(backendOpts.Connection,
grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithDefaultCallOptions(
Expand Down
Loading