fix: Validate and normalize inet test values#2205
Merged
kodiakhq[bot] merged 2 commits intomainfrom Jul 1, 2025
Merged
Conversation
murarustefaan
approved these changes
Jul 1, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
🤖 I have created a release *beep* *boop* --- ## [4.86.1](v4.86.0...v4.86.1) (2025-07-01) ### Bug Fixes * **deps:** Update dependency go to v1.24.4 ([#2209](#2209)) ([6b91b19](6b91b19)) * **deps:** Update golang.org/x/exp digest to b7579e2 ([#2207](#2207)) ([5970950](5970950)) * Validate and normalize inet test values ([#2205](#2205)) ([c9f45a2](c9f45a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/filetypes
that referenced
this pull request
Jul 1, 2025
Regenerates snapshots for tests now that the data is dynamic rather than hardcoded Dependent on cloudquery/plugin-sdk#2205
erezrokah
added a commit
that referenced
this pull request
Jul 23, 2025
This reverts commit c9f45a2.
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
#### Summary Reverts #2205 as we were actually losing the IP data in some cases (in `AppendValueFromString`). This PR ensures we don't lose the IP data ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The inet type, uses the
net.ParseCIDRfunction which when returning the network, actually drop some of the details of the CIDR string that is passed in...This fix ensures that all inet values will be unchanged if they go through a read --> write --> read (like we do in the filetypes tests)
This issue was discovered in the filetypes tests where a value was written to a parquet file then read back into an arrow record where the inet builder normalized the data and when compared to the original record a difference was detected