Skip to content

Comments

chore: Allow additional description to be specified#2323

Closed
stoovon wants to merge 1 commit intomainfrom
docs/permit-additional-documentation
Closed

chore: Allow additional description to be specified#2323
stoovon wants to merge 1 commit intomainfrom
docs/permit-additional-documentation

Conversation

@stoovon
Copy link

@stoovon stoovon commented Nov 7, 2025

Summary

This allows us to add helpful hints like:

The aws_ec2_vpc_endpoint_services table shows data for Amazon Elastic Compute Cloud (EC2) VPC Endpoint Services.

Note: You will usually want to use `WHERE owner != 'amazon'` when querying this table.

The second line is the additional description.

Screenshot 2025-11-07 at 18 18 06

Once this PR is merged, we'll need to modify the documentation generator to render the additional description.


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

This allows us to add helpful hints like:

```
The aws_ec2_vpc_endpoint_services table shows data for Amazon Elastic Compute Cloud (EC2) VPC Endpoint Services.

Note: You will usually want to use `WHERE owner != 'amazon'` when querying this table.
```

The second line is the additional description.
@stoovon stoovon requested a review from a team as a code owner November 7, 2025 18:17
@stoovon stoovon requested a review from dcelasun November 7, 2025 18:17
@stoovon stoovon changed the title docs: Allow additional description to be specified chore: Allow additional description to be specified Nov 7, 2025
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use a multi-line description instead?

@stoovon stoovon closed this Nov 7, 2025
@erezrokah
Copy link
Member

See example https://github.com/cloudquery/cloudquery-private/blob/36b662a1dafe0aa6d6b09603863116313578477a/plugins/source/azure/resources/services/monitor/metrics.go#L18 where we embed a whole markdown file as a description

@stoovon stoovon deleted the docs/permit-additional-documentation branch November 7, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants