chore: Update board item's i18n strings#337
Merged
johannes-weber merged 1 commit intomainfrom Mar 3, 2025
Merged
Conversation
Add instructions to temp disable keyboard navigation while resizing/moving. Why? A screen reader's keyboard navigation mode may intercept arrow key presses. We can't disable that with an appropriate role, that's why we extend the drag handlers description with that information.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
========================================
Coverage 95.71% 95.71%
========================================
Files 61 61
Lines 4321 4321
Branches 669 456 -213
========================================
Hits 4136 4136
Misses 185 185 ☔ View full report in Codecov by Sentry. |
johannes-weber
requested review from
avinashbot and
connorlanigan
and removed request for
a team and
connorlanigan
avinashbot
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add instructions to temp disable keyboard navigation while resizing/moving.
Why? A screen reader's keyboard navigation mode may intercept arrow key presses. We can't disable that with an appropriate role, that's why we extend the drag handlers description with that information.
Updated copy got approved, see CR-180476213.
Related links, issue #, if available:
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.