Skip to content

Conversation

@johannes-weber
Copy link
Member

@johannes-weber johannes-weber commented Jun 6, 2025

Description

This reverts commit aa1f984.

Why? Drag handles in classic has slight diffs. Reverting to investigate before releasing.

Related links, issue #, if available: #356

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@johannes-weber johannes-weber changed the title Revert "feat: Add UAP directional controls and tooltips to drag/resize handles (#356)" revert "feat: Add UAP directional controls and tooltips to drag/resize handles (#356)" Jun 6, 2025
@johannes-weber johannes-weber changed the title revert "feat: Add UAP directional controls and tooltips to drag/resize handles (#356)" revert: "feat: Add UAP directional controls and tooltips to drag/resize handles (#356)" Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 92.71523% with 11 lines in your changes missing coverage. Please review.

Project coverage is 93.87%. Comparing base (aa1f984) to head (1da980d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/internal/item-container/index.tsx 89.81% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   94.98%   93.87%   -1.12%     
==========================================
  Files          67       67              
  Lines        3250     3100     -150     
  Branches      693      665      -28     
==========================================
- Hits         3087     2910     -177     
- Misses        163      190      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannes-weber johannes-weber marked this pull request as ready for review June 6, 2025 17:07
@johannes-weber johannes-weber requested a review from a team as a code owner June 6, 2025 17:07
@johannes-weber johannes-weber requested review from gethinwebster and removed request for a team and gethinwebster June 6, 2025 17:07
@johannes-weber johannes-weber added this pull request to the merge queue Jun 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2025
@johannes-weber johannes-weber added this pull request to the merge queue Jun 6, 2025
Merged via the queue into main with commit 8071ba6 Jun 6, 2025
38 of 42 checks passed
@johannes-weber johannes-weber deleted the jowejowe/revert-add-uap-handles branch June 6, 2025 17:55
johannes-weber pushed a commit that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants