Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Aug 26, 2025

Description

A recently added test (#367) simulates moving cursor close to the screen edge. It passes locally and in PR run, but unfortunately it caused failures in dry-runs: https://github.com/cloudscape-design/components/actions/runs/17243081277

I adjusted the params so that it moves cursor a bit further from the screen edge, which should hopefully be enough. I validated that the test still fails if reverting the auto-scroll changes it was designed to cover.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (95e6e11) to head (de707e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   95.00%   95.39%   +0.39%     
==========================================
  Files          67       67              
  Lines        3282     3282              
  Branches      703      707       +4     
==========================================
+ Hits         3118     3131      +13     
+ Misses        164      151      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot force-pushed the chore-adjust-test-params branch from b0c1b1b to de707e5 Compare August 26, 2025 16:02
@pan-kot pan-kot marked this pull request as ready for review August 26, 2025 16:02
@pan-kot pan-kot requested a review from a team as a code owner August 26, 2025 16:02
@pan-kot pan-kot requested review from mariksav and removed request for a team August 26, 2025 16:02
@pan-kot pan-kot enabled auto-merge August 26, 2025 16:03
@pan-kot pan-kot added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit 992e913 Aug 26, 2025
66 of 68 checks passed
@pan-kot pan-kot deleted the chore-adjust-test-params branch August 26, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants